[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156


Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikhail.pozdnyakov at intel.co
                   |                            |m




--- Comment #15 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2013-05-10 11:40:12 PST ---
(In reply to comment #14)
> (From update of attachment 201345 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201345&action=review
> 
> >> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:53
> >> +    for (i = 0; i < numArgs; i++) {
> > 
> > Nit: prefixed increment for style
> 
> Ah, okay, didn't know it was the preferred style. Thanks.
> 
> >> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:55
> >> +        strcpy(args[i], splitArgs[i].utf8().data());
> > 
> > You are calling utf8() twice, you should probably store the CString in a local variable
> 
> Good point, it makes sense to store the CString and use it here and for the length. I will do that.
> 
> >> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:109
> >> +    ArgsScopeGuard guard(args);
> > 
> > Isn't there a better way to do that? Maybe using OwnArrayPtr or similar? I need to think a bit more about it.
> 
> Good question. I will look into OwnArrayPtr and see if I can find a way to use it here. Thanks for your review and suggestions.
I guess in order to use WTF OwnPtr, you just need to define deleteOwnedPtr(char* const* args), then createArgsArray could return PassOwnPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.