[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156





--- Comment #13 from Christophe Dumez <dchris at gmail.com>  2013-05-10 08:36:23 PST ---
(From update of attachment 201345)
View in context: https://bugs.webkit.org/attachment.cgi?id=201345&action=review

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:53
> +    for (i = 0; i < numArgs; i++) {

Nit: prefixed increment for style

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:54
> +        args[i] = new char[strlen(splitArgs[i].utf8().data()) + 1];

We should not call strlen here as the returned CString stores the size.

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:55
> +        strcpy(args[i], splitArgs[i].utf8().data());

You are calling utf8() twice, you should probably store the CString in a local variable

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:71
> +            for (size_t i = 0; m_args[i]; i++)

++i

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:109
> +    ArgsScopeGuard guard(args);

Isn't there a better way to do that? Maybe using OwnArrayPtr or similar? I need to think a bit more about it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.