[Webkit-unassigned] [Bug 115884] Frame flattening prevents <HTML> in <OBJECT> from having scrollbars

Fri May 10 07:16:04 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=115884

--- Comment #8 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-05-10 07:14:29 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 201309 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=201309&action=review
> > 
> > > Source/WebCore/ChangeLog:11
> > > +        <object> can contain HTML document. But frame flattening prevents this document
> > > +        from creating scrollbars like <iframe> or <frame>. So we can't scroll HTML document
> > > +        in <object> when frame flattening is enabled. Frame flattening should be applied
> > > +        only to <frame> and <iframe>.
> > 
> > The absence of scrollbars should not prevent scrolling. Where in your codepath scrolling bails out due to absence of scrollbars?
> 
> FrameView::avoidScrollbarCreation() is used in ScrollView::updateScrollbars() to decide scrollbar status. If frame flattening is enabled, avoidScrollbarCreation() returns true always, so ScrollView::setHas{Horizontal|Vertical}Scrollbar() is not called properly. It could block normal scroll operations.

(Oops. I clicked 'Commit' by mistake.) 
This patch makes avoidScrollbarCreation() return true only for <frame> and <iframe> when flattening is enabled. <object> tag is excepted.

> 
> > 
> > > Source/WebCore/page/FrameView.cpp:540
> > > +    if ((owner->hasTagName(frameTag) || owner->hasTagName(iframeTag))
> > 
> > Maybe a helper would be more "elegant"?
> 
> I'll try. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.