[Webkit-unassigned] [Bug 115896] [BlackBerry] Use requestAnimationFrame for animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 04:12:02 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115896





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-10 04:10:27 PST ---
(In reply to comment #2)
> (From update of attachment 201330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201330&action=review
> 
> The only call that will happen on a non-UI thread is animationFrameChanged(), perhaps we can invent a "weak" synchronization scheme similar to void WebPagePrivate::updateDelegatedOverlays(bool duringCommit, bool dispatched) to avoid using a mutex.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6333
> > +    BlackBerry::Platform::AnimationFrameRateController::instance()->lockMutex();
> 
> Since addClient() already locks/unlocks the internal mutex, is this external lock/unlock pair really necessary? Perhaps it tries to use the mutex to protect m_isRunningRefreshAnimationClient, since stopRefreshAnimationClient is sometimes called on the UI thread (when it's called from animationFrameChanged)?

I took this approach from the BlackBerry::Platform::AnimationBase implementation, but I think the mutex in this case is to call frameChanged with the lock, so maybe we don't need it here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list