[Webkit-unassigned] [Bug 115896] [BlackBerry] Use requestAnimationFrame for animations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115896





--- Comment #2 from Arvid Nilsson <anilsson at rim.com>  2013-05-10 04:03:57 PST ---
(From update of attachment 201330)
View in context: https://bugs.webkit.org/attachment.cgi?id=201330&action=review

The only call that will happen on a non-UI thread is animationFrameChanged(), perhaps we can invent a "weak" synchronization scheme similar to void WebPagePrivate::updateDelegatedOverlays(bool duringCommit, bool dispatched) to avoid using a mutex.

> Source/WebKit/blackberry/Api/WebPage.cpp:6333
> +    BlackBerry::Platform::AnimationFrameRateController::instance()->lockMutex();

Since addClient() already locks/unlocks the internal mutex, is this external lock/unlock pair really necessary? Perhaps it tries to use the mutex to protect m_isRunningRefreshAnimationClient, since stopRefreshAnimationClient is sometimes called on the UI thread (when it's called from animationFrameChanged)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.