[Webkit-unassigned] [Bug 115556] [CMake] Don't compile SVG/MATHML files if they are not enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 19:09:33 PDT 2013


--- Comment #16 from Ryuan Choi <ryuan.choi at samsung.com>  2013-05-09 19:07:56 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > When I submit a patch, changelog comments are required, which require a "reviewed by" statement, but at that point no one has reviewed the patch.  Sort of a chicken and egg problem...
> > 
> > "Unreviewed" passes the style bot, as well as "Reviewed by <reviewer>".
> Please use "Tools/Scripts/prepare-ChangeLog <directory>". By the way, I still wonder why there is build time difference. All files are guarded by ENABLE(). Let me check this on EFL port again.

I double checked and it was fine in EFL port on linux.
(GCC 4.7.3 witout ccache on ubuntu 13.04 (64bit))

Well, I think that it should improve build performance because gcc does not need to look SVG stuffs.
I am not sure why my GCC(w/o ccache) had small improvement.(Or my GCC is well optimized for empty sourc file?)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list