[Webkit-unassigned] [Bug 115865] Web Inspector: implement runOpenPanel callback for WebKit2-hosted inspector page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115865





--- Comment #2 from Timothy Hatcher <timothy at apple.com>  2013-05-09 16:36:38 PST ---
(From update of attachment 201295)
View in context: https://bugs.webkit.org/attachment.cgi?id=201295&action=review

Looking good!

> Source/WebKit2/UIProcess/WebInspectorProxy.h:99
> +    NSWindow* inspectorWindow() const { return m_inspectorWindow.get(); }

This will only be non-nil when the Inspector is detached. I assume that is what you wanted, since having the open panel as a sheet on the Safari window when docked would be odd.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:37
> +#import "WKRetainPtr.h"

I don't think you use this? You should if you can.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:244
> +            NSURL *nsURL;
> +            for (nsURL in [openPanel URLs]) {

You can put the type in the for().

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:245
> +                WKURLRef wkURL = WKURLCreateWithCFURL((CFURLRef)nsURL);

Use static_cast<CFURLRef>(nsURL) instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.