[Webkit-unassigned] [Bug 115804] Avoid unnecessary data copies when loading subresources with DoNotBufferData option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 11:05:29 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #201083|0                           |1
        is obsolete|                            |
 Attachment #201083|review?                     |
               Flag|                            |
 Attachment #201252|                            |review?
               Flag|                            |

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-09 11:03:53 PST ---
Created an attachment (id=201252)
 --> (https://bugs.webkit.org/attachment.cgi?id=201252&action=review)
New patch

I've renamed the methods, actually I've split data into 3 addDataBuffer and addData to add data chunks to the resource when buffering/not buffering and finishLoading called when all data has been received. this way we get rid of the boolean parameter and cached resources only interested in the final data, only implement finishLoading. I've also noticed that sendDataToResource is confusing, so I've removed it to call resource methods directly. This way is more obvious when data needs to be copied and when to call addData, addDataBuffer or finishLoading.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list