[Webkit-unassigned] [Bug 115804] Avoid unnecessary data copies when loading subresources with DoNotBufferData option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115804





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-08 12:24:15 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #5)
> 
> > > > Source/WebCore/loader/cache/CachedResource.h:105
> > > > +    virtual void data(const char* /*data*/, int /*length*/) { }
> 
> > > Assuming all tests continue passing without that ASSERT firing, I'd like us to take it a step further and name this method something different instead of just overloading ::data().  "unbufferedData()" is my first instinct, though I'm aware that's not perfect.
> > 
> > Yes, I also thought about the names, my initial idea was to rename the current one to buffer or resourceBuffer and this new as data, but I wanted to keep the patch as simple as possible and buffer doesn't sound like a great name anyway. For now, I left both as data so that they can be renamed when refactoring. 
> 
> Please name it something else now.
> 
> "data()" is already such a truly terrible name, and overloading truly terrible names is even more truly terrible.

Yeah, I agree, I'll do it, I thought you also preferred to keep it like this for now and rename it as part of the refactoring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.