[Webkit-unassigned] [Bug 115564] Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115564





--- Comment #20 from Timothy Hatcher <timothy at apple.com>  2013-05-08 10:48:10 PST ---
(From update of attachment 201081)
View in context: https://bugs.webkit.org/attachment.cgi?id=201081&action=review

> Source/WebCore/inspector/InspectorFrontendClientLocal.h:-72
> -    virtual bool canSave() { return false; }
> -    virtual void save(const String&, const String&, bool) { }
> -    virtual void append(const String&, const String&) { }

Correct me if I am wrong, but can't you keep this and eliminate the need to stub out all the other platforms on WK1?

> Source/WebKit2/UIProcess/WebInspectorProxy.h:168
> +    void platformCanSave(bool&);

Any reason not to make this bool platformCanSave()?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:510
> +    // necessary for the block below.

Comments should be have a capital letter starting them.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:525
> +        // the user must confirm new filenames before we can save to them.

Ditto for the first letter of the comment.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:529
> +    }
> +    if (!platformURL)
> +        return;

This should ASSERT(platformURL) before returning early. Also an empty line between the previous and this block would be nice.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:553
> +    // do not append unless the user has already confirmed this filename in save().

Ditto.

These all apply to the WK1 version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.