[Webkit-unassigned] [Bug 115627] [SH4] Misc bugfix and cleaning in sh4 base JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115627





--- Comment #5 from Julien Brianceau <jbrianceau at nds.com>  2013-05-06 13:19:18 PST ---
(In reply to comment #4)
> (From update of attachment 200650 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200650&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:673
> > +        RegisterID scr = (dest == base) ? claimScratch() : dest;
> 
> This seems common enough that you may want to make a function to do it automagically - getScratch(dest, base) or something?
Yes, but in this case I'd also have to make an equivalent "releaseScratch(scr, dest, base)" function. This last one would be a little weird, don't you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.