[Webkit-unassigned] [Bug 115647] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115647





--- Comment #5 from Alejandro Piñeiro <apinheiro at igalia.com>  2013-05-06 10:17:14 PST ---
(In reply to comment #2)
> adding Alejandro Piñeiro and Carlos García to CC

Note that I'm not a reviewer (or a committer in any case), so consider this as an informal review.

Note that the call to the deprecated atk_document_get_locale is done on a if. And the condition is if the object is a document itself (so ensuring that the call will be correct).

So if we replace atk_document_get_locale (document specific) for a more general purpose atk_object_get_object_locale, that if condition doesn't have sense anymore.

In general, I really think that the the implementation of dumprendertree::language should be replaced atk_object_get_object_locale, as is the purpose of both methods are the same.

Just in case someone wonders if the attribute ATK_TEXT_ATTR_LANGUAGE should be deprecated: it is still needed because you can fine-grained requesting the language, as atk_text_get_run_attributes [1] allows you to request the atributtes (so also language) of a specific text range. If having more than one language for each text object is possible depends on the implementor.

Also note that if we replace the implementation of ::language with just a call to atk_object_get_object_locale, probably we will get into a regression, as atk_object_get_object_locale is not implemented at all at webkit atk implementation. 


[1] https://developer.gnome.org/atk/stable/AtkText.html#atk-text-get-run-attributes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.