[Webkit-unassigned] [Bug 115513] Improving PageSerializer.cpp to retrieve the subresources specified in @media rules in css

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115513





--- Comment #29 from Santosh Mahto <santoshbit2007 at gmail.com>  2013-05-06 01:38:19 PST ---
(In reply to comment #27)
> (From update of attachment 200601 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200601&action=review
> 
> > I had attached the test patch before with name Test.html and respective saved file in mhtml Test.mhtml from chromium (one Image is not saved in Test.mhtml file)). Isn't is enough ??
> > Should I attach agin same Test.html again.
> > Actually I am not very used to bugzilla (this is my first time), so plz guide.
> 
> Manual test attached on bugzilla are irrelevant for a patch. You need to have an automated test with your patch.
> 
> Typically tests are written as LayoutTest or API tests. I am unfamiliar with the testing of PageSerializer, you will probably find how it is tested by looking at the previous changes on that class.

This class is triggred when page save in mhtml format is triggred  by UI
e.g save page as in chromium (when save as MHTMl flag is true) and add to reading list is done in safari(I checked ios5). As this code is triggred by UI interface, layout test case is not possible.

On checking previus chekin I found that testcases were under  chromium folder.
and all the checkin reffered to that unit test as
Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp

So I think currently the Test file for this patch is not posible(your views r welcome) 
But definitely we can verified about patch with already  test case and result 
in this bug.


> > Source/WebCore/page/PageSerializer.cpp:285
> > +                RefPtr<StyleRuleBase> rule = rules[i];
> 
> This should be a reference to avoid the ref(). (or alternatively get the pointer in the temporary).

Done .....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.