[Webkit-unassigned] [Bug 115513] Improving PageSerializer.cpp to retrieve the subresources specified in @media rules in css

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115513


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200522|review?                     |review-
               Flag|                            |




--- Comment #24 from Benjamin Poulain <benjamin at webkit.org>  2013-05-04 17:59:45 PST ---
(From update of attachment 200522)
View in context: https://bugs.webkit.org/attachment.cgi?id=200522&action=review

> Source/WebCore/ChangeLog:11
> +        Test file : Test.html (saving this file in mhtml format)

You forgot to include the test in this patch.

> Source/WebCore/page/PageSerializer.cpp:281
> +            WTF::Vector<RefPtr<StyleRuleBase> > rules = mediaStyle->childRules();

Remove the WTF::

> Source/WebCore/page/PageSerializer.cpp:284
> +            unsigned ruleSize = rules.size();
> +            for (unsigned i = 0; i < ruleSize; ++i) {

unsigned -> size_t.

> Source/WebCore/page/PageSerializer.cpp:286
> +                if (rules[i]->isStyleRule())
> +                    retrieveResourcesForRule(static_cast<StyleRule*>(rules[i].get()), document);

Because operator[] is a checked access, you shoudl store rules[i] in a temporary variable:
    RefPtr<StyleRuleBase> rule = rules[i];
    if (rule->etc

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.