[Webkit-unassigned] [Bug 115570] Remove concept of younger and older shadow trees

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115570


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200513|review?                     |review+
               Flag|                            |




--- Comment #14 from Andreas Kling <akling at apple.com>  2013-05-03 20:20:55 PST ---
(From update of attachment 200513)
View in context: https://bugs.webkit.org/attachment.cgi?id=200513&action=review

r=meh

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:86
> +        if (ShadowRoot* root = shadow->shadowRoot()) {

This code no longer holds a ref on the ShadowRoot.

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:104
> +        if (ShadowRoot* root = shadow->shadowRoot())

Ditto.

> Source/WebCore/dom/ElementShadow.cpp:101
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Yuck.

> Source/WebCore/dom/ElementShadow.cpp:111
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Bleh.

> Source/WebCore/svg/SVGUseElement.cpp:397
> -    if (ShadowRoot* shadowTreeRootElement =  shadow()->oldestShadowRoot())
> +    if (ShadowRoot* shadowTreeRootElement =  shadow()->shadowRoot())

Please fix the whitespace here. Then re-run performance tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.