[Webkit-unassigned] [Bug 114742] [texmap] draw content if graphics layer displays a video

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114742





--- Comment #16 from Noam Rosenthal <noam at webkit.org>  2013-05-02 07:59:20 PST ---
(In reply to comment #14)
> After chatting a bit with Simon, he told me that
> 
> 20:25 < smfr> so when m_texture->updateContents() is called, something should just tell AcceleratedCompositingContextGL to just render a new scene
> 20:25 < smfr> you shouldn't be running webcore painting code for every frame
> 
> I reviewed how WebKitGTK+ paints WebGL and here's a backtrace:
> 
> http://people.igalia.com/vjaquez/files/webgl-traceback.txt
> 
> Every time a frame is updated, 
> 
> Hence, if I understand correctly, we should call WebCore::GraphicsLayerTextureMapper:setContentsNeedsDisplay when a new frame is available, directly from WebCore::MediaPlayerPrivateGStreamerBase
> 
> The question is how WebCore::MediaPlayerPrivateGStreamerBase would access to WebCore::GraphicsLayerTextureMapper, or more abstractly: how MediaPlayerPrivate would access GraphicsLayer in an AC setup.

I suggest adding a "Client" to TextureMapperPlatformLayer, that would have something like a setLayerNeedsDisplay. the TextureMapperLayer would inherit from that client and MediaPlayerPrivateGStreamerBase would invoke it when it's ready.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.