[Webkit-unassigned] [Bug 115472] New: web_view_search_text should set set (in)active markers instead of selecting text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 04:19:32 PDT 2013


           Summary: web_view_search_text should set set (in)active markers
                    instead of selecting text
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tradiaz at yahoo.de

In WebKit1's WebView class search_text() selects the next match. mark_text() highlights all matches using DocumentMarkers. search_text() should set the corresponding DocumentMarker active or inactive instead of (only) selecting the next match.

Many applications highlight all search matches using mark_text() and subsequently use search_text() to jump to the next result. One problem with this is that the currently active match and the inactive matches are often hard to discern. 
This is because:

1) Most themes use light colors for their text selection background (worst case: translucent light yellow).

2) The DocumentMarker for active text matches is hard coded to be yellow in.
RenderTheme::platformActiveTextSearchHighlightColor() and the inactive color is hardcoded to be orange.

3) When find_search() selects the next match the yellow from the inactive DocumentMarker and the text selection color are blended together, resulting in hardly any visual difference.

The method provided to keep text matches apart seems to be setting DocumentMarkes (in)active using DocumentMarkerController::setMarkersActive(). Chromium for example uses active and inactive markers in their search function
in WebFrameImpl::find (http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp?revision=149370).
The result is that the highlight color is yellow and the color for the currently selected item is orange.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list