[Webkit-unassigned] [Bug 113568] g_slist_reverse() may not be required in webKitWebAudioSrcLoop
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 29 22:44:56 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113568
--- Comment #4 from Praveen Jadhav <praveen.j at samsung.com> 2013-03-29 22:43:07 PST ---
(In reply to comment #2)
> (From update of attachment 195722 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195722&action=review
>
> Looks good but I'd like to test this patch before landing
>
> > Source/WebCore/ChangeLog:8
> > + Decremental for loop logic implemented to avoid using g_slist_reverse().
>
> This could be expanded a bit, explaining the performance gain.
I tested with basic audiocontext with 2 destination channels only(No other nodes webaudio nodes are created). Calculated the time taken to execute webKitWebAudioSrcLoop() for 100000 iteration and the details are as below.
Original code - 2.025230 micro seconds
Original code + patch - 1.964759 micro seconds
Its a small gain indeed, but a gain nevertheless. Given the frequency with which webKitWebAudioSrcLoop() is called, CPU load should decrease a bit.
>
> > Source/WebCore/ChangeLog:10
> > + No new tests (OOPS!).
>
> You'd need to remove this line unless you state the patch is covered by existing webaudio tests.
I will update the patch shortly.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list