[Webkit-unassigned] [Bug 113357] Web Inspector: gather accessor property getter and setter under a single tree node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113357





--- Comment #25 from Peter Rybin <prybin at chromium.org>  2013-03-28 16:18:49 PST ---
(From update of attachment 195447)
View in context: https://bugs.webkit.org/attachment.cgi?id=195447&action=review

>> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:481
>> +        if (properties[i].value == null)
> 
> == -> ===

Done

>> Source/WebCore/inspector/front-end/RemoteObject.js:218
>>                  if (property.get || property.set) {
> 
> style: no {} around one liners
> I'd rather move this get/set logic into constructor.

Done

>> Source/WebCore/inspector/front-end/RemoteObject.js:453
>> +    if (descriptor && descriptor.get) {
> 
> style: no {} around one liners

Done

>> Source/WebCore/inspector/front-end/RemoteObject.js:456
>> +    if (descriptor && descriptor.set) {
> 
> style: no {} around one liners

Done

>> LayoutTests/inspector/debugger/properties-special.html:71
>> +                if (children[j].nameElement && children[j].nameElement.textContent === "__proto__") {
> 
> style: no {} around one liners

Done

>> LayoutTests/inspector/runtime/runtime-getProperties.html:63
>> +    function convertPropertyValueForTest(propertyObj, fieldName)
> 
> propertyObj -> propertyObject

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.