[Webkit-unassigned] [Bug 92868] [css3-text] Add platform support for "wavy" text decoration style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92868





--- Comment #76 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-03-28 12:40:44 PST ---
(From update of attachment 195421)
View in context: https://bugs.webkit.org/attachment.cgi?id=195421&action=review

>> Source/WebCore/rendering/InlineTextBox.cpp:991
>> +    if (step <= 0 || length <= 0)
> 
> Could step really be <= 0?
> Sounds like this should be an assertion.

I do not think so. I will change the check on step to an assert and keep the one for lenght since it can be 0 if the start and end points of the decoration are the same.

>> Source/WebCore/rendering/InlineTextBox.cpp:1029
>> + *                 step
> 
> Usually I am strongly against comment but I have to say this is great to help understand your code. Good job on this.

Thanks :-)

>> Source/WebCore/rendering/InlineTextBox.cpp:1055
>> +        float x1 = p1.x();
> 
> Maybe name the x1 differently to express it is the stable axis?
> 
> Maybe just xAxis?

I will change it to xAxis and yAxis.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.