[Webkit-unassigned] [Bug 113493] Enhance the restrictions on going through the faster hardware path for uploading Canvas2D to WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113493





--- Comment #4 from Zhenyao Mo <zmo at google.com>  2013-03-28 09:17:23 PST ---
(From update of attachment 195510)
View in context: https://bugs.webkit.org/attachment.cgi?id=195510&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3877
> +        && (texture->getType(target, level) == GraphicsContext3D::UNSIGNED_BYTE || !texture->isValid(target, level))

Actually I don't understand why we care about target texture's previous type?  Looking at https://code.google.com/p/chromium/codesearch#chromium/src/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

I don't see why previous type is relevant.  Probably you can just remove this condition.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3878
> +        && !level) {

Instead of limiting to level == 0 here, why don't we add an extra parameter level to copyToPlatformTexture()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.