[Webkit-unassigned] [Bug 113499] WebCore refactoring of device motion/orientation and fixing of webkit ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113499





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2013-03-28 05:14:05 PST ---
Attachment 195536 did not pass style-queue:

Source/WebCore/page/DeviceController.cpp:54:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/page/DeviceController.cpp:64:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/page/DeviceController.cpp:74:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:41:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:47:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionProviderQt.cpp:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceMotionProviderQt.cpp:42:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp:34:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp:37:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceMotionController.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceMotionController.cpp:44:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/dom/DeviceMotionController.cpp:46:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceMotionController.cpp:59:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/dom/DeviceMotionController.cpp:67:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceMotionController.cpp:71:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:35:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:36:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:37:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:38:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:39:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:40:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceMotionQt.cpp:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:35:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:36:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:37:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:38:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:39:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:42:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/qt/DeviceOrientationQt.cpp:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceMotionChromium.cpp:35:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/DeviceMotionChromium.cpp:36:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/chromium/DeviceMotionChromium.cpp:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/DeviceMotionChromium.cpp:40:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/DeviceOrientationController.cpp:47:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceOrientationController.cpp:48:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/dom/DeviceOrientationController.cpp:50:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceOrientationController.cpp:59:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/dom/DeviceOrientationController.cpp:65:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/dom/DeviceOrientationController.cpp:65:  ShouldFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/Platform.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/dom/DeviceMotionController.cpp', u'Source/WebCore/dom/DeviceMotionController.h', u'Source/WebCore/dom/DeviceOrientationController.cpp', u'Source/WebCore/dom/DeviceOrientationController.h', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DeviceController.cpp', u'Source/WebCore/page/DeviceController.h', u'Source/WebCore/platform/PlatformDeviceMotion.h', u'Source/WebCore/platform/PlatformDeviceOrientation.h', u'Source/WebCore/platform/chromium/DeviceMotionChromium.cpp', u'Source/WebCore/platform/chromium/DeviceOrientationChromium.cpp', u'Source/WebCore/platform/qt/DeviceMotionProviderQt.cpp', u'Source/WebCore/platform/qt/DeviceMotionProviderQt.h', u'Source/WebCore/platform/qt/DeviceMotionQt.cpp', u'Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp', u'Source/WebCore/platform/qt/DeviceOrientationProviderQt.h', u'Source/WebCore/platform/qt/DeviceOrientationQt.cpp', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/src/WebDeviceOrientationController.cpp', u'Source/WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1
 have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/dom/DeviceOrientationController.cpp:74:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/dom/DeviceOrientationController.cpp:79:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 59 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.