[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #38 from Eric Seidel (vacation until 4/3) <eric at webkit.org>  2013-03-27 20:31:19 PST ---
(From update of attachment 194985)
View in context: https://bugs.webkit.org/attachment.cgi?id=194985&action=review

I think this is an *awesome* idea.  I think we just have to be careful of perf when doing this.

> Source/WebCore/page/FeatureObserver.cpp:40
> +static int mapCSSPropertyId(int id)
> +{

I recommend autogenerating this and checking it in.  That will avoid having to type all this out, and yet still make it possible to guarantee that new ones are always added to the end.

> Source/WebCore/page/FeatureObserver.cpp:487
> +    default:
> +        ASSERT_NOT_REACHED();
> +        return 0;

Better to remove the deafult: and have it be a compiler error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.