[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #37 from Kassy Coan <kassycoan at gmail.com>  2013-03-27 17:22:49 PST ---
(In reply to comment #36)

> > Source/WebCore/page/FeatureObserver.cpp:529
> > +    if (flushCSSResults)
> > +        HistogramSupport::histogramEnumeration("WebCore.FeatureObserver.CSSProperties", cssFlushPropertyId(), maximumCSSPropertyId());
> 
> I now understand what the flushing is, but I don't think it's necessary. If we're tracking every CSS property, then literally every page will hit this code. As such, the flushing is redundant with the PageVisits enumeration.

Correct, PageVisits and CSSFlush would be redundant if both are tracked correctly.
PageVisits is not being tracked correctly and I filed a bug about it: https://bugs.webkit.org/show_bug.cgi?id=113461

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.