[Webkit-unassigned] [Bug 113454] GCC 4.8 error - C++ nested class inheriting enclosing class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113454


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195431|review?                     |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2013-03-27 16:41:15 PST ---
(From update of attachment 195431)
View in context: https://bugs.webkit.org/attachment.cgi?id=195431&action=review

> ChangeLog:6
> +2013-03-27  Han Shen  <shenhan at google.com>
> +
> +        Move the definition of nested class that inherits enclosing class outside class definition.
> +
> +        * Source/WTF/wtf/HashMap.h: Move outside nested class definition from enclosing class.
> +

First patch I guess :)

There is a tool to generate the changelogs. Just run "./Tools/Scripts/prepare-ChangeLog --bug 113454"
The ChangeLogs have a certain standard format.

You will also need to include a description. Something similar to what you explains in the bug.

> Source/WTF/wtf/HashMap.h:147
> +            typedef typename HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::iterator::Keys iterator;

Please privately typedef HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg> to avoid the repeated args on every calls.

> Source/WTF/wtf/HashMap.h:186
> -            typedef typename HashMap::iterator::Values iterator;
> -            typedef typename HashMap::const_iterator::Values const_iterator;
> -            
> +            typedef typename HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::iterator::Values iterator;
> +            typedef typename HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::const_iterator::Values const_iterator;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.