[Webkit-unassigned] [Bug 113448] Move preprocessing of idl to pre-pass for gyp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113448





--- Comment #9 from Scott Graham <scottmg at chromium.org>  2013-03-27 15:35:17 PST ---
(In reply to comment #5)
> (From update of attachment 195409 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195409&action=review
> 
> Nice, I like this better than my patch.  Let's clean this up and land this instead.
> 
> > WebCore/WebCore.gypi:716
> > +            'svg/SVGURIReference.idl',
> 
> Is this change intentional?

Yes, it wasn't included in the top-level gyp list, but is referenced in other idls, so it ended up being processed a few hundred times via references. It was the only one in that situation, so I assumed the omission was unintentional. (?)

> 
> > WebCore/bindings/scripts/preprocessor.pm:56
> > +        print "$fileName was not pre-preprocessed, looking for $preprocessedFile\n";
> 
> We probably don't want this to print this.  I think some other port may use $outputDirectory but without the preprocess build step, this will just spam to the console.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.