[Webkit-unassigned] [Bug 113364] Selection code spends a lot of time in InlineTextBox::localSelectionRect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113364





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-27 10:40:16 PST ---
(In reply to comment #5)
> (From update of attachment 195214 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195214&action=review
> 
> Missing ChangeLog file
> 
> >> Source/WebCore/rendering/InlineTextBox.cpp:211
> >> +    if (sPos != 0 || ePos != static_cast<int>(m_len))
> > 
> > Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
> 
> Please fix the style issue and add a comment.

Oh, oops. This wasn't up for review.  The one on https://bugs.webkit.org/show_bug.cgi?id=113358 is. I'm trying to add the performance test first so that people can verify my assertion that my patch improves the performance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.