[Webkit-unassigned] [Bug 110470] [GTK][AC] Animating layer disappears while running with clutter backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110470


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189790|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2013-03-27 10:10:09 PST ---
(From update of attachment 189790)
View in context: https://bugs.webkit.org/attachment.cgi?id=189790&action=review

I could not reproduce this problem in webkit-clutter. I guess it might be a bad interaction with clutter-gtk. The change makes sense anyway. Please merge this change to webkit-clutter master as well! cq- because of the requested changes.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:656
> +        GraphicsLayerClutter* curChild = static_cast<GraphicsLayerClutter*>(childLayers[i]);

Let's take the opportunity to fix the naming here, curChild -> currentChild

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:658
> +        g_assert(GRAPHICS_LAYER_IS_ACTOR(childLayer));

Make this an ASSERT() instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.