[Webkit-unassigned] [Bug 113327] Web Inspector: Exception in console on attempt to filter javascript messages.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 27 07:37:56 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113327
--- Comment #4 from Dmitry Zvorygin <zvorygin at chromium.org> 2013-03-27 07:36:06 PST ---
(From update of attachment 195127)
View in context: https://bugs.webkit.org/attachment.cgi?id=195127&action=review
>> Source/WebCore/inspector/front-end/ConsoleMessage.js:779
>> + if (!this._element) return;
>
> return should be on the next line
Done.
>> Source/WebCore/inspector/front-end/ConsoleView.js:559
>> + } else if (sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroup || sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed) {
>
> This needs a test
Added tests.
>> Source/WebCore/inspector/front-end/ConsoleView.js:673
>> + this._messages.push(message);
>
> Let migrate tests back to this._messages
Tests shouldn't use _messages field, but instead use DOM generated by console.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list