[Webkit-unassigned] [Bug 113327] Web Inspector: Exception in console on attempt to filter javascript messages.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113327


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195127|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2013-03-27 03:13:28 PST ---
(From update of attachment 195127)
View in context: https://bugs.webkit.org/attachment.cgi?id=195127&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:779
> +        if (!this._element) return;

return should be on the next line

> Source/WebCore/inspector/front-end/ConsoleView.js:559
> +                    } else if (sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroup || sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed) {

This needs a test

> Source/WebCore/inspector/front-end/ConsoleView.js:673
> +        this._messages.push(message);

Let migrate tests back to this._messages

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.