[Webkit-unassigned] [Bug 113363] Add a settings to disallow initializing background-size if background shorthand doesn't include it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 21:10:05 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113363


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195213|review?                     |review-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-03-26 21:12:32 PST ---
(From update of attachment 195213)
View in context: https://bugs.webkit.org/attachment.cgi?id=195213&action=review

I think it would be clearer to refer to "legacyBackgroundSizeShorthandBehavior" or something, for the various settings and flags.

> Source/WebCore/css/CSSParser.cpp:287
> +    , shouldResetBackgroundSizeInBackgroundShorthand(!document->settings() || document->settings()->shouldResetBackgroundSizeInBackgroundShorthand())

Shame we fetch settings so many times in this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list