[Webkit-unassigned] [Bug 107539] [ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107539





--- Comment #7 from Tim Horton <timothy_horton at apple.com>  2013-03-26 17:06:27 PST ---
(In reply to comment #6)
> (From update of attachment 194960 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194960&action=review
> 
> > Source/WebCore/platform/mac/WebCoreSystemInterface.mm:195
> > +void(*wkCABackingStoreCollectBlocking)(void);
> 
> I think we should change this name to something less mysterious.

OK.

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:373
> > +    if (!parameters.isInWindow) {
> > +        // Page defaults to on-screen, but setIsInWindow depends on it being a valid indicator of actually having been put into a window.
> > +        m_page->setCanStartMedia(false);
> > +        m_page->willMoveOffscreen();
> > +    }
> 
> Is this behavior change detectable at all? Will it break anything?

I don't think so (on both counts) because it is immediately rectified by setIsInWindow. I do, however, think that we don't need to setCanStartMedia here, because there is no time between when this code runs and when setIsInWindow sets it to the right value, so I'm going to remove that.

Also, I'm glad you pointed this out; this patch is from before the isInWindow vs. willMoveOffscreen disambiguation; it really wants to be doing setIsInWindow(false). I'll fix that.

> > Source/WebKit2/WebProcess/WebProcess.cpp:1078
> > +    m_inWindowPageCount--;
> 
> I think you should assert that m_inWindowPageCount is > 0 here. Consider making it signed for slightly less bad behavior if miscounting occurs in a release build.

Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.