[Webkit-unassigned] [Bug 113197] Web Inspector: log message searching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113197


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194849|review?                     |review-
               Flag|                            |




--- Comment #6 from Vsevolod Vlasov <vsevik at chromium.org>  2013-03-26 10:05:57 PST ---
(From update of attachment 194849)
View in context: https://bugs.webkit.org/attachment.cgi?id=194849&action=review

> Source/WebCore/inspector/front-end/Drawer.js:198
> +            case WebInspector.Drawer.AnimationType.Slow:

please revert this.

> Source/WebCore/inspector/front-end/SearchController.js:250
> +            this._searchHost = WebInspector.drawer;

Why can't you get search provider right here?

> Source/WebCore/inspector/front-end/View.js:432
> +    canSearch: function() {

these methods should be extracted as a separate interface implemented by Panel and ConsoleView

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.