[Webkit-unassigned] [Bug 110487] Ctrl+Shift+Right in Windows should select the spacing after the word

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 06:08:03 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110487





--- Comment #45 from Claudio Saavedra <csaavedra at igalia.com>  2013-03-26 06:10:27 PST ---
(From update of attachment 194615)
View in context: https://bugs.webkit.org/attachment.cgi?id=194615&action=review

Thanks for the review. A few comments follow.

>> Source/WebCore/editing/FrameSelection.cpp:599
>> +        if (pos == wordStart)
> 
> e.g. we can do something like
> bool movingBackwardsTwiceMovedPositionToStartOfCurrentWord = intermiediatePosition == previousWordPosition(nextWordPosition(c));

It would be movingBackwardsMovedPositionToStasrtOfCurrentWord, as we never move backward twice, only once.

>> LayoutTests/ChangeLog:8
>> +        This is a massive review of all tests that use word selection for
> 
> Massive review? or massive rebaseline?

Some tests have been rebaselined, others fixed differently.

>> LayoutTests/TestExpectations:12
>> +webkit.org/b/112240 editing/execCommand/remove-format-multiple-elements-win.html [ Skip ]
> 
> Please don't skip an existing test on all platforms. r- because of this change.
> You may add [ Failure ] expectation on some platform where this test fails but it's not acceptable to disable a test on all platforms.
> If we need to fix a test, then please fix it before submitting a patch on this bug.

It is not an existing test. It is a new test (see the ChangeLog entry fot that test.) It fails because of a completely different bug I have found that is unrelated to this one (bug 112240, already existing and affecting many editor commands). The test fails in all platforms because, as specified by the filename, the test forces a windows editing behavior regardless of the platform where it runs.

Does Failure runs the test anyway? I think that would make sense, but as I said this will fail in all platforms until the bug is addressed. Another option is not to add it or to add an -expected file that takes into consideration the failure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list