[Webkit-unassigned] [Bug 113211] Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113211


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194932|review?                     |review+
               Flag|                            |




--- Comment #11 from Yury Semikhatsky <yurys at chromium.org>  2013-03-26 05:48:19 PST ---
(From update of attachment 194932)
View in context: https://bugs.webkit.org/attachment.cgi?id=194932&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:105
>              for (var i = 0; i < this.extraProperties.length; ++i)

style: please add {} for multiline if block.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:473
> +WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements = function(treeElement, properties, internalProperties, constructor, comparator, skipProto, value) {

wrapPropertyAsElements -> populateWithProperties
constructor -> treeElementConstructor

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.