[Webkit-unassigned] [Bug 92868] [css3-text] Add platform support for "wavy" text decoration style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92868





--- Comment #69 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-03-25 11:52:11 PST ---
(From update of attachment 192958)
View in context: https://bugs.webkit.org/attachment.cgi?id=192958&action=review

>> Source/WebCore/rendering/InlineTextBox.cpp:992
>> +        while (y + 2 * step <= y2) {
> 
> This should be a for() loop.
> 
> Wouldn't this be too short for the tail?

Yes, that can happen. With strokeThickness equals 1 pixel then it can be up to 7 pixels too short. I am not sure how to solve this problem. Do you know to draw a half Bezier curve?

>> Source/WebCore/rendering/InlineTextBox.cpp:1131
>> +            }
> 
> missing break?

No. This part belongs to the "default" part of the switch statement. Break is not necessary here and as far as I know about WebKit's code style it should not be used in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.