[Webkit-unassigned] [Bug 112426] [WK2] Add support for selectTrailingWhitespaceEnabled setting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112426





--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com>  2013-03-25 02:25:49 PST ---
(In reply to comment #2)
> (From update of attachment 193277 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193277&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3819
> > +        setSelectTrailingWhitespaceEnabled(!enabled);
> 
> Is a strict 'not' right here?
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3832
> > +        setSmartInsertDeleteEnabled(!enabled);
> 
> Ditto.

The reason to do that is to keep the behavior of the different ports in WK1 where these 2 settings are mutually exclusive. The only exception is Chromium port, where in some situations these settings are not exclusive, however as Chromium didn't use WK2 I keep a similar approach to WK1 here.

Originally this comes from a comment in WebCore::Editor:
    // smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled are 
    // mutually exclusive, meaning that enabling one will disable the other.
    bool smartInsertDeleteEnabled();
    bool isSelectTrailingWhitespaceEnabled();

Anyway maybe this is not accurate anymore, and we could remove the lines establishing the other setting and everyone using it should be responsible to update it (or not) accordingly.

Let me know what do you think and I can prepare a patch without these 2 lines if needed.

Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.