[Webkit-unassigned] [Bug 113139] Call Netscape Plugin's toString() and valueOf() instead of providing default implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113139





--- Comment #8 from Arunprasad <ararunprasad at gmail.com>  2013-03-24 04:14:53 PST ---
(In reply to comment #7)
> Attachment 194742 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/plugins/npruntime/tostring-expected.txt', u'LayoutTests/plugins/npruntime/tostring.html', u'LayoutTests/plugins/npruntime/valueof-expected.txt', u'LayoutTests/plugins/npruntime/valueof.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/c/c_instance.h', u'Tools/ChangeLog', u'Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp']" exit_code: 1
> Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:97:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:98:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Total errors found: 4 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Oops :(

I just followed the existing style which was used for Plugin Properties, 

enum {
    ID_PROPERTY_FOO = 0,
    ID_PROPERTY_BAR,
    ID_PROPERTY_OBJECT_POINTER,
    ID_PROPERTY_TEST_OBJECT,
    ID_PROPERTY_REF_COUNT,
    NUM_TEST_IDENTIFIERS,
};

Is it a false-positive ? (or) Properties follows very old guidelines? Shall I change all properties & method as indicated by style-checker( enum members should use InterCaps with an initial capital letter.)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.