[Webkit-unassigned] [Bug 113121] AudioNode should be an EventTarget

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113121





--- Comment #2 from Russell McClellan <russell.mcclellan at gmail.com>  2013-03-22 18:29:23 PST ---
There was some discussion here [1] about whether or not ActiveDOMObject was the right way to go on this.  The other obvious option would be a custom binding.  I don't feel strongly either way, but my first patch rejected my first patch for [2] because I used a custom binding.

It is true there's precedence for using ActiveDOMObject only for its GC benefits (e.g. DatabaseContext, AudioContext, MediaSource), so I don't know if this is the place to change strategies.  Maybe at some point it would be good to split out the GC meaning of ActiveDOMObject from the suspendable meaning.

The only perhaps questionable part of this patch is calling suspendIfNeeded directly from the AudioNode constructor.  This fixes some asserts and I don't think this is a big deal, and we can change it if we ever need suspend behavior from AudioNodes.  It seems silly to add a suspendIfNeeded call to every create function in the hierarchy, when the call doesn't do anything.

[1]: https://bugs.webkit.org/show_bug.cgi?id=112858
[2]: https://bugs.webkit.org/show_bug.cgi?id=112521

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.