[Webkit-unassigned] [Bug 113096] [chromium] make layout tests pass on retina displays

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 14:51:33 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113096





--- Comment #10 from Elliott Sprehn <esprehn at chromium.org>  2013-03-22 14:54:00 PST ---
(In reply to comment #8)
> > fast/css-generated-content/001.html , it's actually all pixel tests though.
> 
> Passes for me:
> 
>  ...
> Do I do something wrong? Do I need to pass more flags? (This is with a webkit-in-chromium build)

Do you have an Info.plist in there? I've got a chromium checkout where I deleted the third_party/WebKit dir and replaced it with a webkit checkout. If I add an Info.plist to my DumpRenderTree.app/Contents that contains:

<dict>
    <key>CFBundleDisplayName</key>
    <string>DumpRenderTree</string>
    <key>CFBundleExecutable</key>
    <string>DumpRenderTree</string>
    <key>CFBundleIdentifier</key>
    <string>org.chromium.DumpRenderTree</string>
    <key>CFBundleInfoDictionaryVersion</key>
    <string>6.0</string>
    <key>CFBundleName</key>
    <string>DumpRenderTree</string>
    <key>CFBundlePackageType</key>
    <string>APPL</string>
    <key>NSSupportsAutomaticGraphicsSwitching</key>
    <true/>
    <key>NSHighResolutionCapable</key>
    <string>True</string>
</dict>

and then copy and pasting DumpRenderTree.app so the plist is reloaded enables the checkbox. Then I don't even need to check the checkbox (it's actually unchecked, but enabled now) and I can run and pass the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list