[Webkit-unassigned] [Bug 112898] NRWT: Enable pixel tests when retrying tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 21 19:28:12 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=112898
--- Comment #2 from Dirk Pranke <dpranke at chromium.org> 2013-03-21 19:30:38 PST ---
Created an attachment (id=194417)
--> (https://bugs.webkit.org/attachment.cgi?id=194417&action=review)
one-line patch to force pixel tests on on the retry
So, forcing pixel tests on on the retry should be a one-line change (as demonstrated in the patch I've just attached).
I haven't decided how I feel about this yet, because it's kind of a hack to change the options object, but it may be an acceptable hack.
There's at least a couple of other loose ends ...
as you noted on #webkit, it looks like the files aren't being written into retries/ on the retry. I'm not yet sure how that could be true, since I thought I had tests for this and at first glance the code looks right.
Also, printing out the unexpected results is a little strange; you get [ Failure Pass Failure ].
We might need to make results.html and/or results.json aware of which links (in which directories) to use as well.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list