[Webkit-unassigned] [Bug 111949] Not for landing, bot test only

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111949





--- Comment #23 from Mike Lawther <mikelawther at chromium.org>  2013-03-21 19:10:55 PST ---
(From update of attachment 194402)
View in context: https://bugs.webkit.org/attachment.cgi?id=194402&action=review

> Source/WebCore/page/FeatureObserver.cpp:50
> +    map.add(CSSPropertyColor, 2);

tbh, I was expecting this to be a large switch statement, eg

enum HistogramId {
  HistogramIdColor = 2,
  HistogramIdDirection = 3,
  HistogramIdDisplay = 4,
 ....
  HistogramIdMaximum
  // add new values above the maximum
};

static int getHistogramId(CSSPropertyId id) {
  switch(id) {
  case CSSPropertyIdColor:
    return HistogramIdColor;
  case CSSPropertyIdDirection:
    return HistogramIdDirection;
 ....
   default:
    ASSERT_NOT_REACHED();
  }  

  return -1;  
}

Extraordinarily boring like I said. 

How come you went with the HashMap?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.