[Webkit-unassigned] [Bug 89879] META: StyleResolver does too much and needs refactoring

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89879





--- Comment #3 from Eric Seidel <eric at webkit.org>  2013-03-21 17:36:42 PST ---
At a high-level, my top priority with this work would be to split all the state out of StyleResolver into (at least) 3 separate objects, corresponding to the data lifetime:
1. Document lifetime
2. Resolve lifetime
3. Element-resolve lifetime

Some of this has already been done, but I wanted to re-state for posterity.

I believe StyleResolver could basically just be a state-less (or possibly only resolve-lifetime state) class, who's main purpose is to direct traffic during a style resolve.

All the document-lifetime storage left (if any), should just be moved onto a separate object on Document for clarity of lifetime.

One path forward with this (and on my todo-list) is to simply walk through all of StyleResolver's remaining members and annotate them as to their expected lifetime, similar to what Darin Adler did for Frame methods (sorting them into objects using comments) several years ago as a comment-document vision as to how to break Frame up.  I welcome someone else to post a patch to do such, or I'll eventually get around to doing so. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.