[Webkit-unassigned] [Bug 112081] Printing to PDF should produce internal links when HTML has internal links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112081


Tim Horton <timothy_horton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194177|review?                     |review-
               Flag|                            |




--- Comment #24 from Tim Horton <timothy_horton at apple.com>  2013-03-21 11:30:28 PST ---
(From update of attachment 194177)
View in context: https://bugs.webkit.org/attachment.cgi?id=194177&action=review

> Source/WebCore/page/FrameView.cpp:3490
> +    if (!m_linkedDestinationsValid) {
> +        collectLinkedDestinations(node);
> +        m_linkedDestinationsValid = true;
> +    }

What if you print, the page is mutated via JavaScript, and then you print again? m_linkedDestinations will be stale, right? And contain stale pointers to Elements? Which you will then dereference below?

> Source/WebCore/page/FrameView.cpp:3495
> +        IntRect bb = it->value->renderer()->absoluteBoundingBoxRect();
> +        IntPoint point(bb.x(), bb.y());

Please expand "bb".

> Source/WebCore/page/FrameView.cpp:3496
> +        if (pageRect.contains(point))

What if the bounds are shoved off the page but the bounding box intersects the page? You probably want "intersection of pageRect and 'bb' is not empty", no?

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:1113
> +    return true;

Shouldn't this only return true if the graphics context is backed by e.g. a PDF? Certainly you don't want to do all this work for a bitmap Skia context...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.