[Webkit-unassigned] [Bug 111979] [Qt] Qml WebKit needs preferences to change security knobs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111979





--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2013-03-20 14:17:43 PST ---
(From update of attachment 192450)
View in context: https://bugs.webkit.org/attachment.cgi?id=192450&action=review

Why do you need to expose WebSecurityEnabled?

I am not too worried about the two others but a word of explanation for those would be nice.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:594
> +    d->setAttribute(QWebPreferencesPrivate::UniversalAccessFromFileURLsAllowed, enable);
> +    emit universalAccessFromFileURLsAllowedChanged();

You don't check the original value before emitting the signal?

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:605
> +    d->setAttribute(QWebPreferencesPrivate::FileAccessFromFileURLsAllowed, enable);
> +    emit fileAccessFromFileURLsAllowedChanged();

Ditto.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:616
> +    d->setAttribute(QWebPreferencesPrivate::WebSecurityEnabled, enable);
> +    emit webSecurityEnabledChanged();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.