[Webkit-unassigned] [Bug 110127] [GTK][EFL] HEAD requests changed to GET after 303 redirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110127





--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2013-03-19 13:21:00 PST ---
(From update of attachment 189715)
View in context: https://bugs.webkit.org/attachment.cgi?id=189715&action=review

This looks good to me, but I'd rather have someone with a bit more HTTP test experience double-check the test.

> LayoutTests/ChangeLog:9
> +        Added tests checking HEAD redirection.
> +        Redirected HEAD requests are expected to remain HEAD requests.
> +        (http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)
> +        Marked test as failing for mac.
> +

Something funky happened here. The description should go under the "Reviewed by" line.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:29
> +    var testIndex=0;
> +    var tests = [
> +        {testName:"HEAD-301",method: "HEAD", code:301, expectedMethod:"HEAD"},
> +        {testName: "HEAD-302",method: "HEAD", code:302, expectedMethod:"HEAD"},
> +        {testName:"HEAD-303",method: "HEAD", code:303, expectedMethod:"HEAD"},
> +        {testName: "HEAD-307",method: "HEAD", code:307, expectedMethod:"HEAD"},
> +    ];

Please use consistent spacing around operators and ':' In particular '=' should be surrounded by spaces.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:44
> +        if (++testIndex<tests.length) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.