[Webkit-unassigned] [Bug 112470] Web Inspector: support changing local variables in frontend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112470





--- Comment #4 from Peter Rybin <prybin at chromium.org>  2013-03-19 10:07:58 PST ---
> Maybe test?

I included it into existing test.

> > Source/WebCore/inspector/front-end/RemoteObject.js:59
> > +        this._scopeRef = scopeRef;
> Why not do this._scopeRef = scopeRef; unconditionally ?
Done

> > Source/WebCore/inspector/front-end/RemoteObject.js:122
> > +    console.assert(typeof payload === "object", "Remote object payload should only be an object");
> Do really want to keep this check in production code?
Done

> > Source/WebCore/inspector/front-end/RemoteObject.js:286
> > +        
> Remove empty line.
Done

> > Source/WebCore/inspector/front-end/RemoteObject.js:452
> > +    this.scopeHolder = scopeHolder;
> I'd merge these two objects.
Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.