[Webkit-unassigned] [Bug 112470] Web Inspector: support changing local variables in frontend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112470


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193379|review?                     |review+
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2013-03-18 06:43:07 PST ---
(From update of attachment 193379)
View in context: https://bugs.webkit.org/attachment.cgi?id=193379&action=review

Maybe test?

> Source/WebCore/inspector/front-end/RemoteObject.js:59
> +        this._scopeRef = scopeRef;

Why not do this._scopeRef = scopeRef; unconditionally ?

> Source/WebCore/inspector/front-end/RemoteObject.js:122
> +    console.assert(typeof payload === "object", "Remote object payload should only be an object");

Do really want to keep this check in production code?

> Source/WebCore/inspector/front-end/RemoteObject.js:286
> +        

Remove empty line.

> Source/WebCore/inspector/front-end/RemoteObject.js:452
> +    this.scopeHolder = scopeHolder;

I'd merge these two objects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.