[Webkit-unassigned] [Bug 111670] Implement pinch zoom for bottom-right fixed-position elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111670





--- Comment #13 from Sami Kyöstilä <skyostil at chromium.org>  2013-03-18 04:32:10 PST ---
(From update of attachment 193420)
View in context: https://bugs.webkit.org/attachment.cgi?id=193420&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests. Can't test until chromium patch landed.

Presumably the basic fixed position layer functionality is covered by existing layout tests, right? We just don't have tests for bottom/right fixed things yet.

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:239
> +static void clearPositionConstraintExcept(GraphicsLayer* layer, GraphicsLayer* except)

Bikeshed: clearPositionConstraintExceptForLayer()?

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:267
> +    // Avoid unnecessary commits

I'm not sure I get this. What does clearing the position constraint have to do with commits?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.