[Webkit-unassigned] [Bug 112375] [chromium] Add possibleUserNames to WebPasswordFormData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112375





--- Comment #6 from Garrett Casto <gcasto at chromium.org>  2013-03-15 11:38:28 PST ---
(In reply to comment #5)
> (From update of attachment 193168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193168&action=review
> 
> Is there any way to implement this within the Chrome layer, rather than in the WebKit layer?  It seems strange to have feature implementation code in the Chromium WebKit glue layer.
> 

It looks like this could be implemented in content if we wanted to do that. I made this change because at the moment all parsing for content::PasswordForm happens here and I thought that it made sense to keep it together. Though now that you mention it, I'm not sure if there is a good reason for this code to live in WebKit or if it's just leftover from a time when the Chromium WebKit API wasn't expansive enough.

WebKit reviewers, do you have any thoughts on either if this change should go here or in Chromium, or if this code in general (WebPasswordFormData and WebPasswordFormUtils) should stay in WebKit long term.

> > Source/WebKit/chromium/src/WebPasswordFormUtils.cpp:-104
> > -            // Various input types such as text, url, email can be a username field.
> 
> nit: Did you intentionally remove this comment?

No, good catch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.